Revert #512 and #508 #663
Open
Revert #512 and #508 #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Dec 2, 2024
|
For my own benefit: I realised just now that the recent releases prior to 3.7.0 all came off the 3.6.x branch, which had the above PRs reverted also. I totally missed this branch when doing the latest release, assuming everything was released off master! I think it would be good to get master back to a sane point. Maybe we should not try to merge this PR at all (which we would do just to get 3.7.1 out, and then want to undo anyways for 4) and instead just release 4.0.0 directly now that we've yanked 3.7.0 and deal with the fallout of this major bump. Does that sound fair? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick attempt to revert these PRs mentioned in #662 (comment)